Skip to content

test: add bridge health status keywords#3167

Merged
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:test-bridge-health-keywords
Oct 7, 2024
Merged

test: add bridge health status keywords#3167
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:test-bridge-health-keywords

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Add new Robotframework keywords to make assertions on the bridge health easier.

The keyword will automatically check which bridge service name should be used (e.g. mosquitto or built-in).

Example

Bridge status/health assertions can be done using the following new keywords.

ThinEdgeIO.Bridge Should Be Up    aws

ThinEdgeIO.Bridge Should Be Down    aws

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h30m7.655479999s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Oct 7, 2024
Merged via the queue into thin-edge:main with commit e74a83a Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:testing Theme: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants