Skip to content

refactor: reorder crates/core/c8y_api/src/smartrest/operation.rs#3161

Merged
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:refactor/3144/c8y-api-smartrest-operation
Oct 7, 2024
Merged

refactor: reorder crates/core/c8y_api/src/smartrest/operation.rs#3161
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:refactor/3144/c8y-api-smartrest-operation

Conversation

@rina23q
Copy link
Copy Markdown
Member

@rina23q rina23q commented Oct 4, 2024 •
edited
Loading

Proposed changes

Reorder structs and functions suggested in #3144 (comment). No contents change.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3144

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q
refactor: reorder structs in core/c8y_api/src/smartrest/operation.rs
74b4f54 
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
@rina23q rina23q temporarily deployed to Test Pull Request October 4, 2024 16:49 — with GitHub Actions Inactive
@rina23q rina23q mentioned this pull request Oct 4, 2024
Merged
16 tasks
@rina23q rina23q added the refactoring Developer value label Oct 4, 2024
@rina23q rina23q changed the title refactor: reorder structs in core/c8y_api/src/smartrest/operation.rs refactor: reorder core/c8y_api/src/smartrest/operation.rs Oct 4, 2024
@rina23q rina23q changed the title refactor: reorder core/c8y_api/src/smartrest/operation.rs refactor: reorder src/core/c8y_api/src/smartrest/operation.rs Oct 4, 2024
@rina23q rina23q changed the title refactor: reorder src/core/c8y_api/src/smartrest/operation.rs refactor: reorder crates/core/c8y_api/src/smartrest/operation.rs Oct 4, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 84.93151% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/c8y_api/src/smartrest/operations.rs 84.93% 9 Missing and 2 partials ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 4, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h28m36.166282s

didier-wenzek
didier-wenzek approved these changes Oct 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rina23q rina23q added this pull request to the merge queue Oct 7, 2024
Merged via the queue into thin-edge:main with commit 7f1f0da Oct 7, 2024
@rina23q rina23q deleted the refactor/3144/c8y-api-smartrest-operation branch August 8, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees

No one assigned

Labels

refactoring Developer value

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rina23q @didier-wenzek