Skip to content

fix: add mosquitto as a weak dependency to tedge#3151

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-packaging-mosquitto-dependency
Oct 4, 2024
Merged

fix: add mosquitto as a weak dependency to tedge#3151
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-packaging-mosquitto-dependency

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Oct 3, 2024

Proposed changes

Fix the tedge's linux package dependency to mosquitto by making it a weak dependency so that mosquitto is not installed by default when installing tedge directly (and not via the tedge-full or tedge-minimal virtual linux packages).

This will allow users to install tedge and any other package which depends on tedge (like tedge-agent) to be installed without mosquitto. The virtual packages will have a hard dependency to mosquitto as this is a "typical" setup and mosquitti is required on the main device.

The official thin-edge.io/install.sh script uses the virtual packages, so this does not break and existing behaviour.

FYI: Debian has good documentation which go into details about the package dependency types.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Allow install tedge and any other package which depends on tedge (like tedge-agent) to be installed without mosquitto and use the virtual packages tedge-full and tedge-minimal to have a hard dependency on mosquitto

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from rina23q as a code owner October 3, 2024 08:32
@reubenmiller reubenmiller added the theme:packaging Theme: Packaging and release artefact topics label Oct 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
506 0 2 506 100 1h33m50.660904999s

@reubenmiller reubenmiller added this pull request to the merge queue Oct 4, 2024
Merged via the queue into thin-edge:main with commit 77dfda5 Oct 4, 2024
@reubenmiller reubenmiller deleted the fix-packaging-mosquitto-dependency branch October 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:packaging Theme: Packaging and release artefact topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants