fix: add mosquitto as a weak dependency to tedge#3151
Merged
reubenmiller merged 1 commit intothin-edge:mainfrom Oct 4, 2024
Merged
fix: add mosquitto as a weak dependency to tedge#3151reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller merged 1 commit intothin-edge:mainfrom
Conversation
Allow install tedge and any other package which depends on tedge (like tedge-agent) to be installed without mosquitto and use the virtual packages tedge-full and tedge-minimal to have a hard dependency on mosquitto Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Contributor
Robot Results
|
albinsuresh
reviewed
Oct 4, 2024
albinsuresh
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the tedge's linux package dependency to mosquitto by making it a weak dependency so that mosquitto is not installed by default when installing
tedgedirectly (and not via thetedge-fullortedge-minimalvirtual linux packages).This will allow users to install tedge and any other package which depends on tedge (like tedge-agent) to be installed without mosquitto. The virtual packages will have a hard dependency to mosquitto as this is a "typical" setup and mosquitti is required on the main device.
The official
thin-edge.io/install.shscript uses the virtual packages, so this does not break and existing behaviour.FYI: Debian has good documentation which go into details about the package dependency types.
Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments