fix: check if log exists before trying to upload it#3150
Merged
reubenmiller merged 1 commit intothin-edge:mainfrom Oct 3, 2024
Merged
fix: check if log exists before trying to upload it#3150reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller merged 1 commit intothin-edge:mainfrom
Conversation
3ab4869 to
1341285
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
1341285 to
17a0ecc
Compare
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The tedge-mapper-c8y feature controlled by
c8y.operations.auto_log_upload=on-failure, uploads an operation log based on the given condition. This PR just adds an additional check to only do the upload if the log file exists to avoid scenarios where an event is created with no attachment...this typically occurs when running the tedge-agent on a child device, and the mapper does not yet have access to the related operation log.Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments