Skip to content

feat: allow to init remote access plugin with non-standard user/group#3131

Merged
Ruadhri17 merged 2 commits intothin-edge:mainfrom
Ruadhri17:c8y-remote-non-standard-user
Sep 30, 2024
Merged

feat: allow to init remote access plugin with non-standard user/group#3131
Ruadhri17 merged 2 commits intothin-edge:mainfrom
Ruadhri17:c8y-remote-non-standard-user

Conversation

@Ruadhri17
Copy link
Copy Markdown
Contributor

@Ruadhri17 Ruadhri17 commented Sep 23, 2024

Proposed changes

This PR add two new flags to c8y-remote-access-plugin: --user and --group that can be used only with --init flag. Plugin will now create directory with custom permissions provided by user or change the permissions if file/directory already exists.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.88889% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/c8y_remote_access_plugin/src/lib.rs 0.00% 41 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
506 0 2 506 100 1h24m51.43794s

albinsuresh
albinsuresh previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@albinsuresh albinsuresh dismissed their stale review September 24, 2024 06:35

Just noticed the remote plugin test failure.

didier-wenzek
didier-wenzek approved these changes Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: the system test is failing for a typo.

@Ruadhri17 Ruadhri17 force-pushed the c8y-remote-non-standard-user branch from 003fef4 to 4113070 Compare September 24, 2024 10:22
@Ruadhri17
feat: add arguments for custom user/group when initializing remote ac…
f0217c6 
…cess plugin

Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
@Ruadhri17 Ruadhri17 force-pushed the c8y-remote-non-standard-user branch from 4113070 to 68f0e23 Compare September 24, 2024 10:26
@Ruadhri17
test: add test for initializing remote access plugin with custom user…
7a63142 
…/group

Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
@Ruadhri17 Ruadhri17 force-pushed the c8y-remote-non-standard-user branch from 68f0e23 to 7a63142 Compare September 24, 2024 10:27
rina23q
rina23q approved these changes Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

@reubenmiller reubenmiller added the theme:troubleshooting Theme: Troubleshooting and remote control label Sep 25, 2024
@Ruadhri17 Ruadhri17 added this pull request to the merge queue Sep 30, 2024
Merged via the queue into thin-edge:main with commit 1d32da6 Sep 30, 2024
@Ruadhri17 Ruadhri17 mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rina23q rina23q rina23q approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh albinsuresh left review comments

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@gligorisaev gligorisaev Awaiting requested review from gligorisaev

Assignees

No one assigned

Labels

theme:troubleshooting Theme: Troubleshooting and remote control

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ruadhri17 @albinsuresh @didier-wenzek @rina23q @reubenmiller