ci: format code and add ci check for robotframework formatting#3129
Merged
reubenmiller merged 4 commits intothin-edge:mainfrom Sep 23, 2024
Merged
ci: format code and add ci check for robotframework formatting#3129reubenmiller merged 4 commits intothin-edge:mainfrom
reubenmiller merged 4 commits intothin-edge:mainfrom
Conversation
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
albinsuresh
approved these changes
Sep 23, 2024
Comment on lines
+164
to
+167
| type Read<'a> | ||
| = File | ||
| where | ||
| Self: 'a; |
Contributor
There was a problem hiding this comment.
Hmm... cargo-fmt pushing too far.
Contributor
Author
There was a problem hiding this comment.
Yep. And I always forget to do a rustup update to update all of the Rust components, so it took me awhile to actually run the required version of Rustfmt
Bravo555
approved these changes
Sep 23, 2024
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Run
just formatto apply the formatting to the code base due to:To avoid committing unformatted Robotframework tests, the
format-checkwas extended to also check the formatting of the Robotframework tests as well which is run on PR checks.Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments