Skip to content

test: extend AWS system tests using robotframework-aws library#3097

Merged
reubenmiller merged 5 commits intothin-edge:mainfrom
reubenmiller:aws-system-tests
Sep 23, 2024
Merged

test: extend AWS system tests using robotframework-aws library#3097
reubenmiller merged 5 commits intothin-edge:mainfrom
reubenmiller:aws-system-tests

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Sep 3, 2024

Proposed changes

Extending AWS system tests to include a full end-to-end test by using the new robotframework-aws Robot Framework library.

  • Use AWS access key (stored in github secrets) to access AWS IoT Core API (and mqtt)
  • Add system tests to check AWS server generated certificates (and verify function by sending telemetry data and sending a command to thin-edge.io)
  • Refactor an existing test to use the AWS.Get IoT Url to get the IoT endpoint using the provided credentials (this enables one less secret to maintain)

Note: To run the AWS tests locally you will need to create an access key in AWS and grant it permissions for all IoT actions, then set the following env variables in your .env file.

AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
AWS_REGION=us-east-1

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
505 0 2 505 100 1h31m57.043589999s

Copy link
Copy Markdown
Contributor

@gligorisaev gligorisaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are doing what they were intendet to

@reubenmiller reubenmiller added this pull request to the merge queue Sep 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 21, 2024
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added this pull request to the merge queue Sep 23, 2024
Merged via the queue into thin-edge:main with commit d5a7b67 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:aws Theme: AWS cloud related topics theme:testing Theme: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants