refactor: Simplify config manager control flow#3086
Merged
Bravo555 merged 4 commits intothin-edge:mainfrom Aug 29, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
Contributor
Robot Results
|
11 tasks
rina23q
approved these changes
Aug 29, 2024
Member
rina23q
left a comment
There was a problem hiding this comment.
Looks good. I have small cosmetic suggestion
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
97d9d18 to
a4f7a49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
As in #2904, control flow was simplified by replacing fragmented control flow and hashmaps with tokio tasks and regular async/await.
A test was added to confirm that requests are still processed concurrently.
Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments
Commits are kept small for ease of reviewing, once reviewed I'll merge them and add a description, unless it's not desired.
Fragmented uploads and downloads are only left in
FileCacheActorandLogManagerActor, I will do them in next PRs.