Skip to content

test: mark sporadically failing unit tests as flaky#3029

Merged
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:test-mark-bridge-test-as-flaky
Jul 31, 2024
Merged

test: mark sporadically failing unit tests as flaky#3029
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:test-mark-bridge-test-as-flaky

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Jul 31, 2024

Proposed changes

Mark the following unit tests as flaky:

The failed run was seen in the following CI runs:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 31, 2024 14:21 — with GitHub Actions Inactive
@reubenmiller reubenmiller added theme:testing Theme: Testing skip-release-notes Don't include the ticket in the auto generated release notes theme:mqtt Theme: mqtt and mosquitto related topics labels Jul 31, 2024
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 31, 2024 14:36 — with GitHub Actions Inactive
@reubenmiller reubenmiller enabled auto-merge July 31, 2024 14:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 31, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
486 0 2 486 100 1h26m18.383366s

@reubenmiller reubenmiller changed the title test: mark bridge cloud reconnect test as flaky test: mark sporadically failing unit tests as flaky Jul 31, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Jul 31, 2024
Merged via the queue into thin-edge:main with commit 6c98a22 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Don't include the ticket in the auto generated release notes theme:mqtt Theme: mqtt and mosquitto related topics theme:testing Theme: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants