Skip to content

http_ext: Replace request to httpbin with mock#1985

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
Bravo555:remove-httpbin
May 17, 2023
Merged

http_ext: Replace request to httpbin with mock#1985
reubenmiller merged 1 commit intothin-edge:mainfrom
Bravo555:remove-httpbin

Conversation

@Bravo555
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 commented May 17, 2023 •
edited
Loading

Proposed changes

The request to httpbin service was failing with a 504 for me, so I replaced it with a mock.

The mock is unfortunately HTTP only, so if the intent was to test HTTPS as well, then this PR removes it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 17, 2023 11:08 — with GitHub Actions Inactive
didier-wenzek
didier-wenzek reviewed May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mock is unfortunately HTTP only, so if the intent was to test HTTPS as well, then this PR removes it.

Yes, the point was to test HTTPS connection. But it's okay to removed it as this test is indeed flaky due to its dependency to an external resource.

So okay to merge this PR, once fix the dependency.

@Bravo555
http_ext: Replace request to httpbin with mock
f1a7b8d 
The request to httpbin service was failing with a 504 for me, so I
replaced it with a mock.

Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
didier-wenzek
didier-wenzek approved these changes May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 17, 2023 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
199 0 5 199 100

Passed Tests

Name ⏱️ Duration Suite
Define Child device 1 ID 0.016 s C8Y Child Alarms Rpi
Normal case when the child device does not exist on c8y cloud 2.04 s C8Y Child Alarms Rpi
Normal case when the child device already exists 1.163 s C8Y Child Alarms Rpi
Reconciliation when the new alarm message arrives, restart the mapper 2.34 s C8Y Child Alarms Rpi
Reconciliation when the alarm that is cleared 65.875 s C8Y Child Alarms Rpi
Prerequisite Parent 17.234 s Child Conf Mgmt Plugin
Prerequisite Child 0.496 s Child Conf Mgmt Plugin
Child device bootstrapping 14.87 s Child Conf Mgmt Plugin
Snapshot from device 61.426 s Child Conf Mgmt Plugin
Child device config update 62.588 s Child Conf Mgmt Plugin
Configuration types should be detected on file change (without restarting service) 52.377 s Inotify Crate
Check lock file existence in default folder 2.018 s Lock File
Check PID number in lock file 2.864 s Lock File
Check PID number in lock file after restarting the services 3.142 s Lock File
Check starting same service twice 1.992 s Lock File
Switch off lock file creation 3.6870000000000003 s Lock File
Set configuration when file exists 12.973 s Configuration Operation
Set configuration when file does not exist 7.065 s Configuration Operation
Set configuration with broken url 5.115 s Configuration Operation
Get configuration 5.114 s Configuration Operation
Get non existent configuration file 4.986 s Configuration Operation
Get non existent configuration type 4.636 s Configuration Operation
Update configuration plugin config via cloud 5.065 s Configuration Operation
Modify configuration plugin config via local filesystem modify inplace 1.7189999999999999 s Configuration Operation
Modify configuration plugin config via local filesystem overwrite 4.001 s Configuration Operation
Update configuration plugin config via local filesystem copy 2.774 s Configuration Operation
Update configuration plugin config via local filesystem move (different directory) 2.85 s Configuration Operation
Update configuration plugin config via local filesystem move (same directory) 3.218 s Configuration Operation
Successful firmware operation 71.259 s Firmware Operation
Install with empty firmware name 55.686 s Firmware Operation
Prerequisite Parent 19.775 s Firmware Operation Child Device
Prerequisite Child 8.021 s Firmware Operation Child Device
Child device firmware update 6.285 s Firmware Operation Child Device
Child device firmware update with cache 5.507 s Firmware Operation Child Device
Firmware plugin supports restart via service manager #1932 5.86 s Firmware Operation Child Device Retry
Update Inventory data via inventory.json 1.812 s Inventory Update
Retrieve a JWT tokens 54.656 s Jwt Request
Check running collectd 0.811 s Monitor Device Collectd
Is collectd publishing MQTT messages? 2.814 s Monitor Device Collectd
Check thin-edge monitoring 3.481 s Monitor Device Collectd
Check grouping of measurements 8.616 s Monitor Device Collectd
Update the custom operation dynamically 49.851 s Dynamically Reload Operation
Main device registration 1.8900000000000001 s Device Registration
Child device registration 2.737 s Device Registration
Supports restarting the device 66.874 s Restart Device
Update tedge version from previous using Cumulocity 89.027 s Tedge Self Update
Test if all c8y services are up 60.02 s Service Monitoring
Test if all c8y services are down 56.826 s Service Monitoring
Test if all c8y services are using configured service type 61.858 s Service Monitoring
Test if all c8y services using default service type when service type configured as empty 106.813 s Service Monitoring
Check health status of tedge-mapper-c8y service on broker stop start 23.363 s Service Monitoring
Check health status of tedge-mapper-c8y service on broker restart 25.983 s Service Monitoring
Check health status of child device service 20.711 s Service Monitoring
Successful shell command with output 3.925 s Shell Operation
Check Successful shell command with literal double quotes output 3.628 s Shell Operation
Execute multiline shell command 3.447 s Shell Operation
Failed shell command 3.417 s Shell Operation
Software list should be populated during startup 48.382 s Software
Install software via Cumulocity 68.013 s Software
Software list should only show currently installed software and not candidates 64.277 s Software
Child devices support sending simple measurements 1.558 s Child Device Telemetry
Child devices support sending custom measurements 1.254 s Child Device Telemetry
Child devices support sending custom events 2.201 s Child Device Telemetry
Child devices support sending custom events overriding the type 1.546 s Child Device Telemetry
Child devices support sending custom alarms #1699 1.713 s Child Device Telemetry
Child devices support sending inventory data via c8y topic 1.1360000000000001 s Child Device Telemetry
Child device supports sending custom child device measurements directly to c8y 1.6909999999999998 s Child Device Telemetry
Check retained alarms 51 s Raise Alarms
Thin-edge devices support sending simple measurements 1.822 s Thin-Edge Device Telemetry
Thin-edge devices support sending simple measurements with custom type 1.295 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom measurements 1.448 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom events 1.043 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom events overriding the type 1.254 s Thin-Edge Device Telemetry
Thin-edge devices support sending custom alarms #1699 1.195 s Thin-Edge Device Telemetry
Thin-edge device supports sending custom Thin-edge device measurements directly to c8y 1.428 s Thin-Edge Device Telemetry
Thin-edge device support sending inventory data via c8y topic 1.572 s Thin-Edge Device Telemetry
thin-edge components support a custom config-dir location via flags 26.542 s Config Dir
Validate updated data path used by tedge-agent 0.769 s Data Path Config
Validate updated data path used by c8y-firmware-plugin 10.958 s Data Path Config
Stop tedge-agent service 0.524 s Log Path Config
Customize the log path 0.218 s Log Path Config
Initialize tedge-agent 0.1 s Log Path Config
Check created folders 0.137 s Log Path Config
Remove created custom folders 0.196 s Log Path Config
Install thin-edge via apt 51.57 s Install Apt
Install latest via script (from current branch) 29.552 s Install Tedge
Install specific version via script (from current branch) 26.734 s Install Tedge
Install latest tedge via script (from main branch) 32.166 s Install Tedge
Install then uninstall latest tedge via script (from main branch) 70.422 s Install Tedge
Support starting and stopping services 43.829 s Service-Control
Supports a reconnect 57.946 s Test-Commands
Supports disconnect then connect 56.129 s Test-Commands
Update unknown setting 45.151 s Test-Commands
Update known setting 32.317 s Test-Commands
Stop c8y-configuration-plugin 0.734 s Health C8Y-Configuration-Plugin
Update the service file 0.329 s Health C8Y-Configuration-Plugin
Reload systemd files 1.411 s Health C8Y-Configuration-Plugin
Start c8y-configuration-plugin 0.544 s Health C8Y-Configuration-Plugin
Start watchdog service 10.393 s Health C8Y-Configuration-Plugin
Check PID of c8y-configuration-plugin 0.089 s Health C8Y-Configuration-Plugin
Kill the PID 0.235 s Health C8Y-Configuration-Plugin
Recheck PID of c8y-configuration-plugin 6.554 s Health C8Y-Configuration-Plugin
Compare PID change 0.001 s Health C8Y-Configuration-Plugin
Stop watchdog service 0.238 s Health C8Y-Configuration-Plugin
Remove entry from service file 0.157 s Health C8Y-Configuration-Plugin
Stop c8y-log-plugin 0.231 s Health C8Y-Log-Plugin
Update the service file 0.234 s Health C8Y-Log-Plugin
Reload systemd files 0.857 s Health C8Y-Log-Plugin
Start c8y-log-plugin 0.375 s Health C8Y-Log-Plugin
Start watchdog service 10.483 s Health C8Y-Log-Plugin
Check PID of c8y-log-plugin 0.202 s Health C8Y-Log-Plugin
Kill the PID 0.522 s Health C8Y-Log-Plugin
Recheck PID of c8y-log-plugin 6.469 s Health C8Y-Log-Plugin
Compare PID change 0 s Health C8Y-Log-Plugin
Stop watchdog service 0.24 s Health C8Y-Log-Plugin
Remove entry from service file 0.224 s Health C8Y-Log-Plugin
Stop tedge-mapper 0.369 s Health Tedge Mapper C8Y
Update the service file 0.396 s Health Tedge Mapper C8Y
Reload systemd files 1.454 s Health Tedge Mapper C8Y
Start tedge-mapper 0.521 s Health Tedge Mapper C8Y
Start watchdog service 10.691 s Health Tedge Mapper C8Y
Check PID of tedge-mapper 0.085 s Health Tedge Mapper C8Y
Kill the PID 0.195 s Health Tedge Mapper C8Y
Recheck PID of tedge-mapper 6.824 s Health Tedge Mapper C8Y
Compare PID change 0.001 s Health Tedge Mapper C8Y
Stop watchdog service 0.664 s Health Tedge Mapper C8Y
Remove entry from service file 0.315 s Health Tedge Mapper C8Y
Stop tedge-agent 0.278 s Health Tedge-Agent
Update the service file 0.208 s Health Tedge-Agent
Reload systemd files 0.814 s Health Tedge-Agent
Start tedge-agent 0.265 s Health Tedge-Agent
Start watchdog service 10.582 s Health Tedge-Agent
Check PID of tedge-mapper 0.083 s Health Tedge-Agent
Kill the PID 0.154 s Health Tedge-Agent
Recheck PID of tedge-agent 6.487 s Health Tedge-Agent
Compare PID change 0.001 s Health Tedge-Agent
Stop watchdog service 0.489 s Health Tedge-Agent
Remove entry from service file 0.469 s Health Tedge-Agent
Stop tedge-mapper-az 0.616 s Health Tedge-Mapper-Az
Update the service file 0.386 s Health Tedge-Mapper-Az
Reload systemd files 1.363 s Health Tedge-Mapper-Az
Start tedge-mapper-az 0.362 s Health Tedge-Mapper-Az
Start watchdog service 10.467 s Health Tedge-Mapper-Az
Check PID of tedge-mapper-az 0.103 s Health Tedge-Mapper-Az
Kill the PID 0.195 s Health Tedge-Mapper-Az
Recheck PID of tedge-agent 6.997 s Health Tedge-Mapper-Az
Compare PID change 0.001 s Health Tedge-Mapper-Az
Stop watchdog service 0.278 s Health Tedge-Mapper-Az
Remove entry from service file 0.279 s Health Tedge-Mapper-Az
Stop tedge-mapper-collectd 0.48 s Health Tedge-Mapper-Collectd
Update the service file 0.299 s Health Tedge-Mapper-Collectd
Reload systemd files 1.183 s Health Tedge-Mapper-Collectd
Start tedge-mapper-collectd 0.411 s Health Tedge-Mapper-Collectd
Start watchdog service 10.514 s Health Tedge-Mapper-Collectd
Check PID of tedge-mapper-collectd 0.255 s Health Tedge-Mapper-Collectd
Kill the PID 0.611 s Health Tedge-Mapper-Collectd
Recheck PID of tedge-mapper-collectd 7.105 s Health Tedge-Mapper-Collectd
Compare PID change 0.008 s Health Tedge-Mapper-Collectd
Stop watchdog service 0.24 s Health Tedge-Mapper-Collectd
Remove entry from service file 0.267 s Health Tedge-Mapper-Collectd
tedge-collectd-mapper health status 6.223 s Health Tedge-Mapper-Collectd
c8y-log-plugin health status 5.656 s MQTT health endpoints
c8y-configuration-plugin health status 6.046 s MQTT health endpoints
Publish on a local insecure broker 0.703 s Basic Pub Sub
Publish on a local secure broker 4.587 s Basic Pub Sub
Publish on a local secure broker with client authentication 3.797 s Basic Pub Sub
Check remote mqtt broker #1773 2.267 s Remote Mqtt Broker
Wrong package name 0.264 s Improve Tedge Apt Plugin Error Messages
Wrong version 0.217 s Improve Tedge Apt Plugin Error Messages
Wrong type 0.462 s Improve Tedge Apt Plugin Error Messages
tedge_connect_test_positive 0.439 s Tedge Connect Test
tedge_connect_test_negative 2.498 s Tedge Connect Test
tedge_connect_test_sm_services 8.324 s Tedge Connect Test
tedge_disconnect_test_sm_services 0.609 s Tedge Connect Test
Install thin-edge.io 22.303 s Call Tedge
call tedge -V 0.106 s Call Tedge
call tedge -h 0.089 s Call Tedge
call tedge -h -V 0.094 s Call Tedge
call tedge help 0.075 s Call Tedge
tedge config list 0.239 s Call Tedge Config List
tedge config list --all 0.121 s Call Tedge Config List
set/unset device.type 0.781 s Call Tedge Config List
set/unset device.key.path 0.756 s Call Tedge Config List
set/unset device.cert.path 0.796 s Call Tedge Config List
set/unset c8y.root.cert.path 0.862 s Call Tedge Config List
set/unset c8y.smartrest.templates 0.698 s Call Tedge Config List
set/unset az.root.cert.path 0.491 s Call Tedge Config List
set/unset az.mapper.timestamp 0.493 s Call Tedge Config List
set/unset mqtt.bind_address 0.636 s Call Tedge Config List
set/unset mqtt.port 0.634 s Call Tedge Config List
set/unset tmp.path 0.579 s Call Tedge Config List
set/unset logs.path 0.695 s Call Tedge Config List
set/unset run.path 0.488 s Call Tedge Config List
Get Put Delete 1.8090000000000002 s Http File Transfer Api
Set keys should return value on stdout 0.065 s Tedge Config Get
Unset keys should not return anything on stdout and warnings on stderr 0.147 s Tedge Config Get
Invalid keys should not return anything on stdout and warnings on stderr 0.131 s Tedge Config Get
Set configuration via environment variables 0.427 s Tedge Config Get
Set unknown configuration via environment variables 0.047 s Tedge Config Get

@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 17, 2023 11:47 — with GitHub Actions Inactive
@reubenmiller reubenmiller merged commit 9aa5c4e into thin-edge:main May 17, 2023
@reubenmiller
Copy link
Copy Markdown
Contributor

reubenmiller commented May 17, 2023

Merging as this issue was blocking the release pipeline.

@Bravo555 Bravo555 deleted the remove-httpbin branch May 17, 2023 13:46
@didier-wenzek didier-wenzek mentioned this pull request Jan 31, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bravo555 @reubenmiller @didier-wenzek