A round of clean-up/clarifications #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
Briefly describe the requirement for unique identification of files for consistent snapshots and cross-link to "6.2. Consistent snapshots" for more information. Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
mnm678
previously approved these changes
Dec 14, 2021
lukpueh
previously approved these changes
Dec 15, 2021
Member
lukpueh
left a comment
There was a problem hiding this comment.
LGTM, I have one suggestions but it's not a blocker.
Co-authored-by: lukpueh <luk.puehringer@gmail.com>
mnm678
approved these changes
Jan 4, 2022
lukpueh
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor clean-up/clarification patches based on some recent reading and discussion of the spec: