Topology2: add sof-ptl-rt722-96k support #9679
Merged
kv2019i merged 2 commits intothesofproject:mainfrom Nov 27, 2024
Merged
Conversation
Deep buffer should use the same rate as the original device. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Set 96KHz rate in jack and deef buffer PCMs. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
lgirdwood
approved these changes
Nov 25, 2024
kv2019i
reviewed
Nov 26, 2024
Collaborator
kv2019i
left a comment
There was a problem hiding this comment.
Looks good. Only one question whether the 96 tplg file should be production or development.
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | ||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
| JACK_RATE=96000,DEEP_BUF_JACK_RATE=96000" | ||
|
|
Collaborator
There was a problem hiding this comment.
Is production folder correct place for this? I don't think we have any kernel configuration that would use this out-of-the-box...?
Member
There was a problem hiding this comment.
yes production is the right place.
Collaborator
Author
There was a problem hiding this comment.
Is production folder correct place for this? I don't think we have any kernel configuration that would use this out-of-the-box...?
Currently, there is no product uses the tplg by default. However, it can be used with options snd-sof-pci tplg_filename=sof-ptl-rt722-96k.tplg
kv2019i
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 96KHz support on jack and deep buffer PCMs on the sof-ptl-rt722.tplg.