ext_manifest: include probe information by CONFIG_PROBE#9675
ext_manifest: include probe information by CONFIG_PROBE#9675lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
Put probe information into manifest by CONFIG_PROBE=y would
be better.
This change could help to avoid annoying kernel log from SOF
loader ("unknown sof_ext_man header type 3 size 0x30") if
CONFIG_PROBE=n.
Signed-off-by: Shawn Huang <shawn.huang724@realtek.com>
|
Can one of the admins verify this patch?
|
|
test this please |
|
Thanks @Shawn-Huang724 -- it's seems this annoyance has gone unfixed for a very long time. It would seem thesofproject/linux#5183 is probably the best fix. At least for Intel, the new FW releases use IPC4 so will not trigger the warning in IPC3 loader in kernel. |
Very much agree, it's better for the doer to undo what he has done. [thesofproject/linux#5183] is the best fix of this annoyance in dmesg log. |
lgirdwood
left a comment
There was a problem hiding this comment.
Ack - manifest should only contain extensions if they are enabled in build, I think in this case the author may have been trying to cover both probes and injectors.
kv2019i
left a comment
There was a problem hiding this comment.
I was wondering @lgirdwood if some client requires the manifest entry to exist (with just probe and injection points as zero in the manifest), but it seems all CI tests are passing and I can't find any usage. So would seem good to go.
Put probe information into manifest by CONFIG_PROBE=y would be better.
This change could help to avoid annoying kernel log from SOF loader ("unknown sof_ext_man header type 3 size 0x30") if CONFIG_PROBE=n on most SOF machines.