Skip to content

Zephyr: A subset of #9522 to fix #9659#9662

Merged
kv2019i merged 4 commits intothesofproject:mainfrom
lyakh:zephyr
Nov 22, 2024
Merged

Zephyr: A subset of #9522 to fix #9659#9662
kv2019i merged 4 commits intothesofproject:mainfrom
lyakh:zephyr

Conversation

@lyakh
Copy link
Collaborator

@lyakh lyakh commented Nov 18, 2024 •
edited
Loading

Recent Zephyr LLEXT updates seem to have introduced ELF layout changes, which require updated SOF support

@lyakh
Copy link
Collaborator Author

lyakh commented Nov 18, 2024 •
edited
Loading

the actual important test - LNL HDA - didn't test, need to retest https://sof-ci.01.org/sofpr/PR9662/build9366/devicetest/index.html

@lyakh
Copy link
Collaborator Author

lyakh commented Nov 18, 2024

SOFCI TEST

@lyakh lyakh mentioned this pull request Nov 18, 2024
Merged
@lyakh lyakh force-pushed the zephyr branch 2 times, most recently from a73c90d to aa6fd3e Compare November 20, 2024 10:54
@lyakh lyakh marked this pull request as ready for review November 20, 2024 13:04
@lyakh
Copy link
Collaborator Author

lyakh commented Nov 20, 2024

CI: Internal Intel CI failed a TGL SSP test. This PR touches LLEXT code, which isn't used on TGL, and upgrades Zephyr. Can this be a Zephyr regression on TGL? @wszypelt @kv2019i

@lgirdwood
Copy link
Member

lgirdwood commented Nov 20, 2024

CI: Internal Intel CI failed a TGL SSP test. This PR touches LLEXT code, which isn't used on TGL, and upgrades Zephyr. Can this be a Zephyr regression on TGL? @wszypelt @kv2019i

TGL SSP is unrelated here, @wszypelt can you remove the TGL SSP test since this is a non production use case with Zephyr config. TGL Zephyr is developers only, so we can tolerate.

lyakh added 4 commits November 21, 2024 07:50
@lyakh
LLEXT: (cosmetic) replace IMR with DRAM
099754c 
IMR is architecture-specific, use a generic DRAM term.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
LLEXT: align .bss for verification
c32a520 
When verifying whether .bss is correctly following .data take its
alignment into account.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
LLEXT: copy individual sections
8f6ddb4 
Section alignment might differ in the ELF image and at module target
address. To obey that we need to copy sections individually from
regions / segments.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
west.yml: update zephyr to include LLEXT fixes
cc26dd9 
Update to include Zephyr fixes for unaligned section placement in
object files.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@wszypelt
Copy link

wszypelt commented Nov 21, 2024 •
edited
Loading

@lgirdwood @lyakh
it seems that the errors were sporadic, now is good to merge.
Should I remove the SSP tests or maybe stop checking TGL with IPC4 at all, maybe it would be good if you discussed it with the decision-makers, I will adjust to the choice.

@lyakh
Copy link
Collaborator Author

lyakh commented Nov 21, 2024

jenkins compilation seems to be hanging, restart

@lyakh
Copy link
Collaborator Author

lyakh commented Nov 21, 2024

SOFCI TEST

lgirdwood
lgirdwood approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: nitpick for future updates would be to include a LOG_VERBOSE() to show what is being copied where and when.

@lyakh
Copy link
Collaborator Author

lyakh commented Nov 22, 2024

SOFCI TEST

@lyakh lyakh changed the title Zephyr: check if 3 commits from #9522 fix #9659 Zephyr: A subset of #9522 to fix #9659 Nov 22, 2024
@lyakh
Copy link
Collaborator Author

lyakh commented Nov 22, 2024

CI: only known failures

@kv2019i kv2019i merged commit 475f0e3 into thesofproject:main Nov 22, 2024
@lyakh lyakh deleted the zephyr branch November 22, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

@kv2019i kv2019i kv2019i approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lyakh @lgirdwood @wszypelt @kv2019i