Merged
Conversation
Contributor
Author
|
FYI @lyakh |
added 3 commits
November 8, 2024 00:23
Fix copy-paste error from SOF_MODULE_INIT() macro call. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Add declaration for symbol probe_is_backend_configured(). Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
The probe logging back-end does not use the ctx argument of log_backend_activate() for anything and putting the hook-function there is just a result of brainless copy-pasting from mtrace implementation. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
lyakh
reviewed
Nov 8, 2024
The only valid log identifier should be full_id == 0, not anything with module_id == 0. This is not a functional problems as 0 should not be a valid module_id value. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
The declarations do not cause any harm, even if the implementation is not compiled in. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Export base firmware symbols needed for modular probes. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Remove the single assert() pulls in problematic symbols for llext. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
To build PROBE as module just set CONFIG_PROBE=m in Kconfig. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Contributor
Author
I was waiting for zephyrproject-rtos/zephyr#81098 to be merged, but since it now has already two approvas, I think its Ok now to mark this ready for review. |
lgirdwood
approved these changes
Nov 18, 2024
lyakh
approved these changes
Nov 19, 2024
|
|
||
| config PROBE_POINTS_MAX | ||
| int "Maximum probe points" | ||
| depends on PROBE |
Collaborator
There was a problem hiding this comment.
I think now with the if above you don't need these depends any more - here and below?
kv2019i
reviewed
Nov 19, 2024
Collaborator
kv2019i
left a comment
There was a problem hiding this comment.
Looks ok to me. I guess we have to wait for the Zephyr PR to be merged as this series enables module build.
| config PROBE | ||
| bool "Probes enabled" | ||
| tristate "Probes enabled" | ||
| default m if LIBRARY_DEFAULT_MODULAR |
Collaborator
There was a problem hiding this comment.
I guess this means we can't merge this before the Zephyr PR is merged...
Collaborator
Collaborator
|
sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Intel+Linux+Daily+tests%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For probe llext module to work, this zephyrproject-rtos/zephyr#81098 needs to be merged to Zephyr tree.