app: board: Add define CONFIG_COUNTER#9636
Conversation
lgirdwood
left a comment
There was a problem hiding this comment.
@gbernatxintel do we need this on other Intel configs ?
kv2019i
left a comment
There was a problem hiding this comment.
Minor notes to git commit, otherwise good.
| @@ -43,6 +43,7 @@ CONFIG_SOF_LOG_LEVEL_INF=y | |||
| CONFIG_ZEPHYR_LOG=y | |||
There was a problem hiding this comment.
you can use: "app: intel_adsp_ace30_ptl.conf: enable CONFIG_COUNTER" prefix.
Also in commit, I think it's also to mention the test case (even if it's not a public test), but I'd also add a brief sentence CONFIG_COUNTER is required for implementation of basefw_get_ext_system_time(). This makes it easily to look up which piece of code this affects.
There was a problem hiding this comment.
Thank you for your comment, I have corrected the commit title and commit message, regarding the test it has no test cases. It is simply such a test and does not take parameters
A new definition has been added, which is crucial for the proper execution of the test test_102_08_extended_time_check. This definition ensures the correct operation of the basefw_get_ext_system_time() function. Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
5446c44 to
d38f41b
Compare
kv2019i
left a comment
There was a problem hiding this comment.
Thanks @gbernatxintel !
|
SOFCI TEST |
A definition has been added which is essential
to work properly the test test_102_08_extended_time_check.