app: intel_adsp_ace20_lnl.conf: clean up board config file#9620
Merged
kv2019i merged 1 commit intothesofproject:mainfrom Oct 28, 2024
Merged
app: intel_adsp_ace20_lnl.conf: clean up board config file#9620kv2019i merged 1 commit intothesofproject:mainfrom
kv2019i merged 1 commit intothesofproject:mainfrom
Conversation
Group the configuration options per theme, separate SOF and Zephyr Kconfig settings and order the entries in alphabetical order within each group. This makes the board config file much more readable and easy to maintain. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Collaborator
Author
|
@tmleman and others: I now separated SOF and Zephyr config options in this PR. If this looks better, I can rework the MTL board file as well using this grouping. |
serhiy-katsyuba-intel
approved these changes
Oct 28, 2024
lgirdwood
approved these changes
Oct 28, 2024
tmleman
approved these changes
Oct 28, 2024
Contributor
tmleman
left a comment
There was a problem hiding this comment.
Thanks again for the great work. Comparing MTL with LNL now, I see the advantages of keeping settings that are related (such as those related to logging) in groups. But ultimately, the version with the division into SOF and Zephyr is, in my opinion, better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group the configuration options per theme, separate SOF and Zephyr Kconfig settings and order the entries in alphabetical order within each group. This makes the board config file much more readable and easy to maintain.
Resulting board file (as diff is a bit hard to read): https://github.com/kv2019i/sof/blob/0e04e7eb9186bbd07497d41737c5d435adf1a388/app/boards/intel_adsp_ace20_lnl.conf