Audio: Multiband-DRC: Tune: Updates to setup tool after moving then to modules, blob updates to pass a quality check#9599
Merged
lgirdwood merged 5 commits intothesofproject:mainfrom Oct 25, 2024
Conversation
This patch fixes paths to moved utilities from DRC, EQ, and crossover. The paths are changed and common utilities are prefixed with sof_. The same sof prefix add is done for Mltiband-DRC. There are no functional changes and changes to config blob data contents from this patch. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This change allows to tune all bands parameters from script top level. It prepares for a better testable default blob for the component. The actual setup blobs data is not impacted by this same since the parameters are kept the same. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The plot is useful to see impact of emphasis/de-emphasis filter parameters. The patch adds two arguments to function sof_iir_gen_quant_coefs() for rate and enable to show in the plot when enabled and with a frequency scale in x-axis. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This change helps the default blob to pass the coarse audio quality check that is done in scripts/host-testbench.sh. The knee and limiting region of each band is brought down from threshold -24 to -40 to avoid signal clipping. It helps to pass the -1 dBFS chirp in the test. The band edge frequencies are moved up for test purpose to better see the band edges. The emphasis of high frequencies is changed with parameter stage_gain to much less than 1 dB to keep the feature active in testing performance but not impacting much to processed audio. The emphasis filter with previous setting caused a lot of distortion and may need revisit in coefficients calculation or filter scaling. These parameters are not final. The better default parameters for e.g. a notebook speaker are for further study. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
New blob for testing that passes the scripts/host-testbench.sh audio quality test. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
approved these changes
Oct 21, 2024
johnylin76
approved these changes
Oct 23, 2024
cujomalainey
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the impacts of moving tools for other modules (Crossover, DRC, EQ) and updates the blob, so that multiband-DRC test can be executed in ipc4 testbench with scripts/host-testbench. The ipc3 version test passed only because it was using a pass-through blob. The previous default blob with processing enabled failed to too strong distortion.
The patch also adds to multiband-DRC design example plot of emphasis/de-emphasis response to better understand the impact of emphasis parameters.