Add missing header includes to init.c and IPC3 handler#9596
Merged
lgirdwood merged 2 commits intothesofproject:mainfrom Oct 21, 2024
Merged
Add missing header includes to init.c and IPC3 handler#9596lgirdwood merged 2 commits intothesofproject:mainfrom
lgirdwood merged 2 commits intothesofproject:mainfrom
Conversation
It's not legal to include platform/lib/mailbox.h directly. Fix the code to include sof/lib/mailbox.h. This has worked only because the mailbox header is included indirectly by other headers. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
The alloc.h header depends on PLATFORM_DCACHE_ALIGN, but does not include sof/lib/memory.h, but relies for the definition to be available indirectly. Fix this and make the include statement explicit. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
lgirdwood
approved these changes
Oct 18, 2024
lyakh
approved these changes
Oct 21, 2024
Member
|
@lgirdwood in Internal Intel CI, everything's fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small series to fix header dependencies. Unrecovered while cleaning up RTOS headers and noticed these files won't compile unless e.g. trace.h pulls a bunch of common headers.