topology2: add support for rt721-sdw topology#9524
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Oct 25, 2024
Merged
topology2: add support for rt721-sdw topology#9524lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
bardliao
reviewed
Sep 30, 2024
| "cavs-sdw\;sof-ptl-rt721\;PLATFORM=ptl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\ | ||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | ||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
| HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9" |
Collaborator
There was a problem hiding this comment.
Does it assume PCH DMIC is used? So that your HDMI IDs are 7, 8, and 9. If so, you have to append -4ch or -2ch to the topology name.
Contributor
Author
There was a problem hiding this comment.
updated.. per suggestion.
thanks
Collaborator
There was a problem hiding this comment.
I think HDMI IDs will be 5, 6, 7 which are the default of HDMI1_D, HDMI2_ID and HDMI3_ID. IOW, we don't need HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9 for the with SDW-DMIC version.
Contributor
Author
There was a problem hiding this comment.
Thanks, have updated accordingly.
04252f6 to
fe82a75
Compare
Member
|
@bardliao good for you now ? |
Collaborator
No, @naveen-manohar please remove |
fe82a75 to
424a625
Compare
Adding topology support for rt721-sdw monolithic codec verified on ptl-rvp, with configuration: 1. sof-ptl-rt721: uses SDW-DMIC 2. sof-ptl-rt721-4ch: uses PCH-DMIC Signed-off-by: Naveen Manohar <naveen.m@intel.com>
424a625 to
daf2b5e
Compare
lgirdwood
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding topology support for rt721-sdw monolithic codec
Verified on PTL-RVP