Skip to content

tools: plugin: noise_suppression: Fix build error#9412

Merged
lgirdwood merged 1 commit intothesofproject:mainfrom
ranj063:main-082124
Sep 2, 2024
Merged

tools: plugin: noise_suppression: Fix build error#9412
lgirdwood merged 1 commit intothesofproject:mainfrom
ranj063:main-082124

Conversation

@ranj063
Copy link
Collaborator

@ranj063 ranj063 commented Aug 28, 2024

Recent changes to UUID naming dropped the _comp in the UUID declaration. Fix the noise suppression module to adhere to the new naming while declaring the module interface and trace.

@ranj063
tools: plugin: noise_suppression: Fix build error
2ff0e6e 
Recent changes to UUID naming dropped the _comp in the UUID declaration.
Fix the noise suppression module to adhere to the new naming while
declaring the module interface and trace.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
Copy link
Collaborator Author

ranj063 commented Aug 28, 2024

@marc-hb @fredoh9 I wonder why CI didnt flag this build error

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2024 •
edited
Loading

@marc-hb @fredoh9 I wonder why CI didnt flag this build error

Which error?

Are you compiling exactly like CI does? "CI secrets" / differences is an unfortunately common issue. In this case however everything is in .github/, no secret.

@ranj063
Copy link
Collaborator Author

ranj063 commented Aug 28, 2024 •
edited by marc-hb
Loading

@marc-hb @fredoh9 I wonder why CI didnt flag this build error

Which error?

Are you compiling exactly like CI does? "CI secrets" / differences is an unfortunately common issue. In this case however everything is in .github/, no secret.

Yes, no difference in the way im compiling vs CI.
Here's the error I'm seeing:

FAILED: modules/ov_noise_suppression/CMakeFiles/sof_ns.dir/noise_suppression.c.o 
/usr/bin/cc -Dsof_ns_EXPORTS -DRELATIVE_FILE=\"modules/ov_noise_suppression/noise_suppression.c\" -I/home/ranjani/work/sof/sof/tools/plugin/modules/ov_noise_suppression -I/home/ranjani/work/sof/sof/tools/plugin/modules/ov_noise_suppression/.. -I/home/ranjani/work/sof/sof/tools/plugin/modules/ov_noise_suppression/../pipe -I/home/ranjani/work/sof/sof/tools/plugin/../../src/audio -I/home/ranjani/work/sof/sof/build-plugin/sof_ep/install/include -I/home/ranjani/work/sof/sof/build-plugin/sof_parser/install/include -fPIC -DPIC -g -O3 -Wall -Werror -DCONFIG_LIBRARY -imacros/home/ranjani/work/sof/sof/build-plugin/sof_ep/build/library_autoconfig.h -MD -MT modules/ov_noise_suppression/CMakeFiles/sof_ns.dir/noise_suppression.c.o -MF modules/ov_noise_suppression/CMakeFiles/sof_ns.dir/noise_suppression.c.o.d -o modules/ov_noise_suppression/CMakeFiles/sof_ns.dir/noise_suppression.c.o -c /home/ranjani/work/sof/sof/tools/plugin/modules/ov_noise_suppression/noise_suppression.c
In file included from /home/ranjani/work/sof/sof/build-plugin/sof_ep/install/include/rtos/alloc.h:21,
                 from /home/ranjani/work/sof/sof/build-plugin/sof_ep/install/include/sof/audio/audio_stream.h:23,
                 from /home/ranjani/work/sof/sof/build-plugin/sof_ep/install/include/sof/audio/buffer.h:11,
                 from /home/ranjani/work/sof/sof/tools/plugin/modules/ov_noise_suppression/noise_suppression.c:7:
/home/ranjani/work/sof/sof/tools/plugin/modules/ov_noise_suppression/noise_suppression.c:34:37: error: ‘ns_comp_uuid_ldc’ undeclared here (not in a function); did you mean ‘ns_uuid_ldc’?
   34 | DECLARE_TR_CTX(ns_comp_tr, SOF_UUID(ns_comp_uuid), LOG_LEVEL_INFO);

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2024 •
edited
Loading

Compilation works for me, no need for this PR.

noise_suppression.c is not compiled by default, you probably want add this.

Yes, no difference in the way im compiling vs CI.

Afraid there is.

@ranj063
Copy link
Collaborator Author

ranj063 commented Aug 28, 2024

Compilation works for me, no need for this PR.

noise_suppression.c is not compiled by default, you probably want add this.

Yes, no difference in the way im compiling vs CI.

Afraid there is.

Ahh I guess we only compile this when openvino is installed. oh well

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2024

Ahh I guess we only compile this when openvino is installed.

How hard is it to install it? I bet we've done harder things: df1ba22

@ranj063
Copy link
Collaborator Author

ranj063 commented Aug 28, 2024

Ahh I guess we only compile this when openvino is installed.

How hard is it to install it? I bet we've done harder things: df1ba22

It is not that hard to install @fredoh9 can we please do it?

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2024

It is not that hard to install @fredoh9 can we please do it?

@ranj063 for everything in sof/.github/ workflows we use the stateless, Ubuntu runners provided by Github by default. So we re-install everything needed every time. This is usually very little except for the Zephyr builds.

So if you really want this to happen we need a 100% automated OpenVino install on Ubuntu. Or even better: a Debian package.

@lgirdwood lgirdwood merged commit 847b2ae into thesofproject:main Sep 2, 2024
@ranj063 ranj063 deleted the main-082124 branch September 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta dbaluta approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@kv2019i kv2019i kv2019i approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ranj063 @marc-hb @dbaluta @lgirdwood @kv2019i