Audio: Volume: Fix problem with Hifi4#9408
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Sep 2, 2024
Merged
Conversation
Collaborator
Author
|
This patch continues fixing the issues from work in #9158. Need to fix for both gain and peakvolume the normal and pass-through mode code versions. |
kv2019i
reviewed
Aug 27, 2024
Collaborator
kv2019i
left a comment
There was a problem hiding this comment.
One question inline, otherwise looks good.
This patch fixes an issue with gain and peakvolume processing with s16 sample format and with sample rates where period is not multiple of four samples SIMD processing assumption. With 44.1 kHz rate the period is normally 44 frames but every 10th is 45. However, the value of 45 was not handled correctly. A Glitch appeared to output when this happened. The fixed code adds sample-by-sample volume process code for the remaining amount of up to 3 samples to process. The earlier workaround (87571f3 "audio: volume: disable HIFI4 optimizations") is reverted. Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
5905e05 to
880e71a
Compare
kv2019i
approved these changes
Aug 27, 2024
gbernatxintel
approved these changes
Aug 28, 2024
lgirdwood
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue with gain and peakvolume processing with s16 sample format and with sample rates where period is not multiple of four samples SIMD processing assumption. With 44.1 kHz rate the period is normally 44 frames but every 10th is 45. However, the value of 45 was not handled correctly. A Glitch appeared to output when this happened.
The fixed code adds sample-by-sample volume process code for the remaining amount of up to 3 samples to process.
The earlier workaround (87571f3 "audio: volume: disable HIFI4 optimizations") is reverted.