topology2: sdw-dmic-generic: add eqiir to control DC offset#9331
Merged
lgirdwood merged 2 commits intothesofproject:mainfrom Aug 5, 2024
Merged
topology2: sdw-dmic-generic: add eqiir to control DC offset#9331lgirdwood merged 2 commits intothesofproject:mainfrom
lgirdwood merged 2 commits intothesofproject:mainfrom
Conversation
Member
Author
|
@ranj063 I can't figure out how instance numbers are handled/generated, if I used the array notation it seems the instance is a global value across all pipelines? That's not how IPC4 defines the instance number, is it? |
The widget should only be defined in the scope of a pipeline, otherwise the instance management is global instead of local to the pipeline. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
For some reason we had the EQIIR for topology1/IPC3 but we didn't add it for topology2/IPC4. All recordings show there's a strong DC offset with RT722 and other codecs, so let's add this component by default in the non-passthrough cases. The widget is added in the scope of a pipeline, so that the auto-generated instance is not handled at a global level. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
7357a04 to
22b227d
Compare
Member
Author
|
v2: use auto-generated instance numbers and inherit pipeline index. The widget is now added as eqiir.41.0
|
singalsu
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason we had the EQIIR for topology1/IPC3 but we didn't add it for topology2/IPC4. All recordings show there's a strong DC offset with RT722 and other codecs, so let's add this component by default in the non-passthrough cases.
FIXME: the instance numbers for eqiir don't look quite right, for some reason we cannot use eqiir.41.0, as if the instance number was global and not in the scope of a pipeline?