[SKIP SOF-TEST] xtensa-build-zephyr.py: move PTL out of "all" and into "extra".#9266
Merged
kv2019i merged 2 commits intothesofproject:mainfrom Jul 2, 2024
Merged
[SKIP SOF-TEST] xtensa-build-zephyr.py: move PTL out of "all" and into "extra".#9266kv2019i merged 2 commits intothesofproject:mainfrom
kv2019i merged 2 commits intothesofproject:mainfrom
Conversation
As reported in thesofproject#9262, this fixes the --all option. Fixes commit 05bfc36 ("ptl: Add initial PTL configuration") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Add a test to avoid --all breakages like the one in commit 05bfc36 ("ptl: Add initial PTL configuration"), reported in thesofproject#9262 See also previous commit. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
andyross
approved these changes
Jun 27, 2024
Contributor
andyross
left a comment
There was a problem hiding this comment.
Sure, thought I'd personally prefer to fix this with a toolchain. Though really that's properly a bug for Zephyr sdk-ng and not SOF per se.
fredoh9
reviewed
Jun 27, 2024
| aliases: list = dataclasses.field(default_factory=list) | ||
| ipc4: bool = False | ||
|
|
||
| # These cannot be built by everyone out of the box yet. |
Contributor
There was a problem hiding this comment.
Eventually toolchain will be availalbe later? Then FIXME or TODO placeholder may be nicer?
Otherwise looks good.
Collaborator
Author
There was a problem hiding this comment.
Eventually toolchain will be availalbe later?
Yes hopefully. As @andyross said: this is a Zephyr SDK issue.
fredoh9
approved these changes
Jun 27, 2024
cujomalainey
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #9262, this fixes the --all option.
Fixes commit 05bfc36 ("ptl: Add initial PTL configuration")