Skip to content

ipc4: return ipc4 error status instead of posix error#5799

Merged
lgirdwood merged 1 commit intothesofproject:mainfrom
RanderWang:ipc4_error_refine
May 12, 2022
Merged

ipc4: return ipc4 error status instead of posix error#5799
lgirdwood merged 1 commit intothesofproject:mainfrom
RanderWang:ipc4_error_refine

Conversation

@RanderWang
Copy link
Collaborator

Convert posix error to ipc4 error and return ipc4 error for
functions in ipc4 directory.

fixes #5737

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also return 0 in ipc4_create_pipeline(), in ipc_comp_connect(), ipc_comp_disconnect() should be return IPC4_SUCCESS. Also a bit strange, that a static function process_dma_index() in that file returns POSIX error codes, although they're replaced with IPC4 codes later, so, it isn't really a bug

Convert posix error to ipc4 error and return ipc4 error for
functions in ipc4 directory.

Signed-off-by: Rander Wang <rander.wang@intel.com>
@lgirdwood
Copy link
Member

also return 0 in ipc4_create_pipeline(), in ipc_comp_connect(), ipc_comp_disconnect() should be return IPC4_SUCCESS. Also a bit strange, that a static function process_dma_index() in that file returns POSIX error codes, although they're replaced with IPC4 codes later, so, it isn't really a bug

@RanderWang can you make this a new PR to align these other functions with correct IPC4 return codes.

@RanderWang RanderWang force-pushed the ipc4_error_refine branch from c3b92d1 to 7255cdb Compare May 11, 2022 13:08
@RanderWang
Copy link
Collaborator Author

@lgirdwood @lyakh updated according to your comments. Thanks!

@lgirdwood lgirdwood merged commit 1e7220e into thesofproject:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][IPC4] wrong error handling in IPC4, potentially leading to missed failures

5 participants