ASoC: SOF: sof-client-probes-ipc4: Set param_size extension bits#5221
Merged
bardliao merged 1 commit intothesofproject:topic/sof-devfrom Oct 31, 2024
Merged
ASoC: SOF: sof-client-probes-ipc4: Set param_size extension bits#5221bardliao merged 1 commit intothesofproject:topic/sof-devfrom
bardliao merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
Write the size of the optional payload of SOF_IPC4_MOD_INIT_INSTANCE message to extension param_size-bits. The previous IPC4 version does not set these bits that should indicate the size of the optional payload (struct sof_ipc4_probe_cfg). The old firmware side component code works well without these bits, but when the probes are converted to use the generic module API, this does not work anymore. Fixes: ba98c69 (ASoC: SOF: IPC4: probes: Implement IPC4 ops for probes client device) Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
ranj063
approved these changes
Oct 30, 2024
lgirdwood
approved these changes
Oct 30, 2024
bardliao
approved these changes
Oct 31, 2024
ujfalusi
reviewed
Nov 1, 2024
| msg.primary |= SOF_IPC4_MSG_TARGET(SOF_IPC4_MODULE_MSG); | ||
| msg.extension = SOF_IPC4_MOD_EXT_DST_MOD_INSTANCE(INVALID_PIPELINE_ID); | ||
| msg.extension |= SOF_IPC4_MOD_EXT_CORE_ID(0); | ||
| msg.extension |= SOF_IPC4_MOD_EXT_PARAM_SIZE(sizeof(cfg)/sizeof(uint32_t)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write the size of the optional payload of SOF_IPC4_MOD_INIT_INSTANCE message to extension param_size-bits.
The previous IPC4 version does not set these bits that should indicate the size of the optional payload (struct sof_ipc4_probe_cfg). The old firmware side component code works well without these bits, but when the probes are converted to use the generic module API, this does not work anymore.
Fixes: ba98c69 (ASoC: SOF: IPC4: probes: Implement IPC4 ops for probes client device)