ASoC: SOF: move ops to sof_dev_desc#482
Merged
plbossart merged 1 commit intothesofproject:topic/sof-devfrom Jan 3, 2019
Merged
ASoC: SOF: move ops to sof_dev_desc#482plbossart merged 1 commit intothesofproject:topic/sof-devfrom
plbossart merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
4b65fe6 to
be2861e
Compare
bardliao
commented
Dec 25, 2018
RanderWang
reviewed
Dec 26, 2018
RanderWang
reviewed
Dec 26, 2018
sound/soc/sof/debug.c
Outdated
RanderWang
reviewed
Dec 26, 2018
sound/soc/sof/intel/hda.c
Outdated
plbossart
reviewed
Dec 26, 2018
Member
plbossart
left a comment
There was a problem hiding this comment.
The move looks ok but I agree with @RanderWang that the indirections are a bit too hard to follow. Maybe use a macro or static inline to get the ops and arch_ops.
c55c223 to
6aaa5bc
Compare
Collaborator
Author
|
@plbossart @RanderWang New version is pushed. Could you review it? Thanks. |
Collaborator
|
@bardliao is this move really necessary? I mean the ops and arch_ops are already abstracted even if they are part of snd_sof_dev. I think it makes sense to leave these as is. |
Collaborator
Author
|
@ranj063 It is from @plbossart 's suggestion :) #431 (comment) |
snd_sof_dsp_ops and sof_arch_ops are hardware specific stuff, so move them from snd_sof_dev to sof_dev_desc. Signed-off-by: Bard liao <yung-chuan.liao@linux.intel.com>
plbossart
reviewed
Jan 2, 2019
Member
plbossart
left a comment
There was a problem hiding this comment.
Looks mostly good but a couple of misses and enhancements needed. Thanks!
beee056 to
bd71f8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snd_sof_dsp_ops and sof_arch_ops are hardware specific stuff, so move
them from snd_sof_dev to sof_dev_desc.
Signed-off-by: Bard liao yung-chuan.liao@linux.intel.com