Simplify Background::class manipulator#428
Simplify Background::class manipulator#428ADmad merged 1 commit intothephpleague:masterfrom olivervogel:feature/simplify-background-manipulator
Conversation
Intervention Image has already a method `blendTransparency()` to do this taks. It is therefore not necessary to carry out the individual steps manually.
|
While looking into this I found that setting |
|
Problem seems to occur only when blue color is involved. If I use |
|
I think the definition of the default background color in |
Yes, The problem I described above only occurs when using |
I'm not sure but maybe it's better to revert my changes. |
|
I'll try to look into it a bit more over the weekend and then decide. Will also try to submit a test case / minimal example for the issue. |
|
I am going to revert this. The blending color is only used when outputting to image format which does not support transparency. But when |


For the calls of the Background
bgmanipulator Intervention Image has already an own methodblendTransparency()to set the background color of the image.This patch simplifies the
Background::classmanipulator in that way and replaces the manual individual steps with the mentioned method.