Skip to content

Fixed param typo#418

Merged
ADmad merged 2 commits intothephpleague:3.xfrom
deluxetom:3.x-missing-param
Dec 20, 2024
Merged

Fixed param typo#418
ADmad merged 2 commits intothephpleague:3.xfrom
deluxetom:3.x-missing-param

Conversation

@deluxetom
Copy link
Contributor

@deluxetom deluxetom commented Dec 20, 2024

Had a typo for an API param

I wonder if we should throw an exception when a manipulator gets a param that's not allowed?

@ADmad ADmad merged commit d6539da into thephpleague:3.x Dec 20, 2024
@ADmad ADmad added this to the 3.x milestone Dec 20, 2024
@ADmad
Copy link
Collaborator

ADmad commented Dec 20, 2024

I wonder if we should throw an exception when a manipulator gets a param that's not allowed?

Well Api::run() calls that the setParams() of each manipulator before running it. If we were to add an exception we would have to first get the valid params list of each manipulator and filter out the "invalid" ones. I don't think there's anything to be gained by doing that, it would just add CPU cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants