Merged
Conversation
ADmad
reviewed
Dec 20, 2024
Collaborator
ADmad
left a comment
There was a problem hiding this comment.
.gitattributes needs to the updated to "export-ignore" the new composer config files.
composer.json
Outdated
| "phpunit/phpunit": "^10.5 || ^11.0", | ||
| "friendsofphp/php-cs-fixer": "^3.48" | ||
| "friendsofphp/php-cs-fixer": "^3.48", | ||
| "phpstan/phpstan": "^1.10 || ^2.0" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "phpstan/phpstan": "^1.10 || ^2.0" | |
| "phpstan/phpstan": "^2.0" |
v1 vs v2 can generate slightly different error report
Dockerfile
Outdated
|
|
||
| # install dependencies | ||
| RUN apt update && apt install -y --no-install-recommends \ | ||
| libvips42 \ |
Collaborator
There was a problem hiding this comment.
Let's hold off the dependencies for vips until we are able to actually support it.
Contributor
Author
|
@ADmad PR updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This made my life much easier in the last couple of days, so I wanted to share.
Some dependencies are only for
php-vips, I'm currently working on getting theinterventiondriver forvipsready.I would love for Glide to also support the
vipsdriver as it is very fast and uses fewer resources