Ensure original type is preserved when fm is not specified.#415
Merged
Conversation
1e21c15 to
03eac2e
Compare
deluxetom
approved these changes
Dec 19, 2024
Contributor
|
Thanks for the easier fix, you took care of the issue with that test already it looks like: |
Earlier, if `fm` was not specified then an image with mime-type "image/x-webp" would get encoded as jpg instead of webp, since the mime type is not include in the Encoder::supportedFormats() list.
03eac2e to
0b35312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, if
fmwas not specified then an image with mime-type "image/x-webp" would get encoded as jpg instead of webp, since the mime type is not include in the Encoder::supportedFormats() list.