Exception message is hidden#398
Merged
ADmad merged 2 commits intothephpleague:masterfrom Jun 25, 2024
Merged
Conversation
|
It would be really nice to have this fix. |
Art4
reviewed
Jun 25, 2024
src/Server.php
Outdated
| ); | ||
| } catch (FilesystemV2Exception $exception) { | ||
| throw new FilesystemException('Could not write the image `'.$cachedPath.'`.'); | ||
| throw new FilesystemException('Could not write the image `'.$cachedPath.'`. ' . $exception->getMessage()); |
Contributor
There was a problem hiding this comment.
Why not directly inserting the catched exception?
Suggested change
| throw new FilesystemException('Could not write the image `'.$cachedPath.'`. ' . $exception->getMessage()); | |
| throw new FilesystemException('Could not write the image `'.$cachedPath.'`. '.$exception->getMessage(), 0, $exception); |
Contributor
Author
There was a problem hiding this comment.
Makes sense, updated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took too long to find a cause of a not working cache setup. The real issue was wrong bucket setup:
So exceptions should not be hidden as they do help to solve the problem easier.