[Docs]: Remove signature params for Laravel integration#375
Merged
ADmad merged 1 commit intothephpleague:masterfrom Dec 1, 2023
pxlrbt:patch-2
Merged
[Docs]: Remove signature params for Laravel integration#375ADmad merged 1 commit intothephpleague:masterfrom pxlrbt:patch-2
ADmad merged 1 commit intothephpleague:masterfrom
pxlrbt:patch-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I know that the example code doesn't show any usage combined with signed routes (maybe that's worth an example, too?), but since it's not a big change, I think it might make sense to remove the signature params from the request in the example.
I used that code, made the route signed later on and DoS my server with cache images 😅 Just want to prevent others from making the same mistake.
Cheers,
Dennis