Add Mark (highlight) extension#1100
Merged
colinodell merged 6 commits intothephpleague:mainfrom Nov 26, 2025
Merged
Conversation
Member
|
Thanks for suggesting this! Although I've been hesitant to include new extensions in this library, I'm inclined to include this one because:
Yep, that works for me! There are a few small changes I think we should make:
I've got some free time now, so I'll give that a go :) |
Member
|
Thanks for contributing this! I'll include this in the next minor release (v2.8.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a feature request to add a highlight extension to Commonmark (see the Markdown Guide's documentation on this feature). This extension is not loaded by default, but is available for implementations that want to support highlighting.
This was quite straightforward, since it merely involved copying and modifying the Strikethrough extension and its tests.
The one unanswered question I have is whether
markis the correct return value forgetXmlTagName()for this extension.