fix(ci): regen model-catalog + mock macOS relaunch fixup in gui tests#1
Merged
Merged
Conversation
Two failures inherited from the latest upstream sync merge (ae9f745): - test_model_catalog: code lists renamed minimax/minimax-m2.7 -> minimax/minimax-m3 but website/static/api/model-catalog.json was not regenerated. Ran scripts/build_model_catalog.py. - test_gui_command: upstream PR NousResearch#36198 (79f7e7a) added _desktop_macos_relaunchable_fixup() to cmd_gui, which fires two extra subprocess.run calls (xattr + codesign) on darwin between pack and launch, but did not update the gui tests. The two darwin tests supplied only [pack_ok, launch_ok] as side_effect, so the launch call hit StopIteration. Mock the fixup helper in those tests, matching the existing pattern that mocks _run_npm_install_deterministic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI on
main(run 26739597466, commit ae9f745 — the latest upstream sync merge) fails two test slices. Both are stale artifacts / un-updated tests inherited from the upstream sync.Fixes
Slice 3 —
tests/hermes_cli/test_model_catalog.pyUpstream renamed
minimax/minimax-m2.7→minimax/minimax-m3in the in-code provider lists, butwebsite/static/api/model-catalog.jsonwas not regenerated. The manifest guard test diffs the two. Regenerated viascripts/build_model_catalog.py(2 id lines change).Slice 6 —
tests/hermes_cli/test_gui_command.pyUpstream PR NousResearch#36198 (
79f7e7a1e) added_desktop_macos_relaunchable_fixup()tocmd_gui, which fires two extrasubprocess.runcalls (xattr+codesign) on darwin between pack and launch — but did not update the gui tests. The two darwin tests supplied onlyside_effect=[pack_ok, launch_ok], so the launch call hitStopIteration. Mock the fixup helper in those two tests, matching the existing pattern that mocks_run_npm_install_deterministic(helper-level, not its internal subprocess calls).Verification
Ran at the exact failing commit (ae9f745):
test_model_catalog.py— 28 passedtest_gui_command.py— 8 passed🤖 Generated with Claude Code