Disable extra vars via environment variable#76
Merged
evgeni merged 2 commits intotheforeman:masterfrom May 7, 2025
Merged
Conversation
evgeni
requested changes
May 7, 2025
obsah/__init__.py
Outdated
| Whether to allow --extra-vars parameter to be automatically added | ||
| """ | ||
| return True | ||
| return os.environ.get('OBSAH_ALLOW_EXTRA_VARS', True) |
Member
There was a problem hiding this comment.
data from the environment is represented as strings, and "0" is True-thy in Python (and Ruby).
You'd need to do something like
if value := os.environ.get('OBSAH_ALLOW') is not None:
return value.lower() in ['true', '1']
return TrueSigned-off-by: Eric D. Helms <ericdhelms@gmail.com>
f69b87a to
1200950
Compare
evgeni
reviewed
May 7, 2025
evgeni
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.