Abstract away Vagrant as the VM provider to speed up subsequent calls#132
Merged
ehelms merged 1 commit intotheforeman:masterfrom Apr 18, 2025
Merged
Abstract away Vagrant as the VM provider to speed up subsequent calls#132ehelms merged 1 commit intotheforeman:masterfrom
ehelms merged 1 commit intotheforeman:masterfrom
Conversation
Contributor
archanaserver
left a comment
There was a problem hiding this comment.
Since this PR introduces new scripts (start-vms/stop-vms) and changes inventory handling, could we update the README.md file.
| mkdir -p inventories | ||
| vagrant up $@ | ||
|
|
||
| ./vagrant.py --yaml > inventories/local_vagrant |
Contributor
There was a problem hiding this comment.
start-vms script currently overwrites inventories/local_vagrant without any checks, should we preserve the existing inventory file when regenerating?
Member
Author
There was a problem hiding this comment.
Since the intent is that this script controls the creation of these VMs, I do not see a reason to preserve the inventory in any way.
Introduces a script to start and stop VMs and produce a static inventory. This speeds up each call after the fact and creates less reliance on Vagrant. Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
17de3a7 to
62e6583
Compare
Member
Author
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a script to start and stop VMs and produce a static inventory. This speeds up each call after the fact and creates less reliance on Vagrant.