Use 10.16 for -sdk_version#2
Merged
thefloweringash merged 2 commits intothefloweringash:apple-siliconfrom Dec 8, 2020
Merged
Conversation
21 tasks
This really should be from the target platform, but I think it's okay to use in this case. We have 11 for aarch64 and 10.12 for x86_64.
10.16 is the only sdk we have available for aarch64 so use that. Hopefully we can update x86_64 to it soon too.
138479c to
cd92ef3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix some broken C++.