Drop AbortController as it breaks fdir on Node v14#153
Merged
Conversation
SuperchupuDev
approved these changes
Jul 2, 2025
benmccann
approved these changes
Jul 2, 2025
Contributor
|
We should probably add Node 12 or whatever the oldest version we want to support is to the CI |
Contributor
sadly we can't, vitest 0.x only works on node >=16 (someone tried already iirc) |
Owner
Author
|
@SuperchupuDev maybe we can get rid of vitest for something that does work on older node versions. AFAIK there's nothing special we require that vitest provides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a workaround until we can drop support for Node v14. Since AbortController is not exposed anywhere, we can replace it with a custom implementation.