Skip to content

stream_filter_append & stream_filter_prepend use mixed instead of array#395

Merged
Kharhamel merged 3 commits intothecodingmachine:masterfrom
ildyria:fix-stream-filter-append
Oct 7, 2022
Merged

stream_filter_append & stream_filter_prepend use mixed instead of array#395
Kharhamel merged 3 commits intothecodingmachine:masterfrom
ildyria:fix-stream-filter-append

Conversation

@ildyria
Copy link
Contributor

@ildyria ildyria commented Sep 29, 2022 •
edited
Loading

https://www.php.net/manual/en/function.stream-filter-append.php
Defines stream_filter_append as :

stream_filter_append(
    resource $stream,
    string $filtername,
    int $read_write = ?,
    [mixed](https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.mixed) $params = ?
): resource

This PR aims to fix the inconsistency as here $params is defined as array.

Also updates https://www.php.net/manual/en/function.stream-filter-prepend.php

@ildyria ildyria mentioned this pull request Sep 29, 2022
Merged
@Kharhamel
Copy link
Collaborator

Kharhamel commented Oct 1, 2022

You cannot directly update the generated files because the change will be lost the next time we will regenerate them. You need to update the generator instead.

To solve this, the simple solution is to edit this file: https://github.com/thecodingmachine/safe/blob/master/generator/config/CustomPhpStanFunctionMap.php
To make stream_filter_append return the type you want

@ildyria ildyria force-pushed the fix-stream-filter-append branch from 9c73c97 to 483b042 Compare October 1, 2022 20:40
@ildyria
Copy link
Contributor Author

ildyria commented Oct 1, 2022

@Kharhamel I updated as you advised.

@ildyria ildyria changed the title stream_filter_append use mixed instead of array stream_filter_append & stream_filter_prepend use mixed instead of array Oct 1, 2022
@Kharhamel Kharhamel merged commit e788f3d into thecodingmachine:master Oct 7, 2022
@Kharhamel
Copy link
Collaborator

Kharhamel commented Oct 7, 2022

Thank you for the MR. I will deploy this shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ildyria @Kharhamel