Skip to content

Replace PSR-4 with classmap autoloader#350

Merged
Kharhamel merged 1 commit intothecodingmachine:masterfrom
j3j5:classmap-replaces-psr4
May 9, 2022
Merged

Replace PSR-4 with classmap autoloader#350
Kharhamel merged 1 commit intothecodingmachine:masterfrom
j3j5:classmap-replaces-psr4

Conversation

@j3j5
Copy link
Contributor

@j3j5 j3j5 commented Apr 28, 2022

I am once again asking for your support trying to fix #253.

I think this is the best approach (as discussed on the phpdocparser issue ) and it's also much less disruptive than the renaming of all files done in #338.

I've tested the code with this repo, but please, test it yourselves to make sure I don't break anything else again 😛

Hope this is the good one!

@Kharhamel
Copy link
Collaborator

This looks really easy. I need to think about how to test this on a bigger scale. I will probably create a beta for this but this means i need to merge this into master.

@j3j5
Copy link
Contributor Author

j3j5 commented May 2, 2022

Yeah, please double check that I didn't miss any class. The only downside is that if a new class is ever added that doesn't fall in the folders (new exceptions will be fine), it'll need to be added manually. I don't think there will be another case like Datetime in this library, but something to be aware of.

@szepeviktor
Copy link
Contributor

@j3j5 I think #348 is the ultimate solution.

@j3j5
Copy link
Contributor Author

j3j5 commented May 2, 2022

As I mentioned on previous attempts, I don't mind which approach we use, I just want to get rid of the error so whatever is easier/better for the actual maintainers :)

@Kharhamel
Copy link
Collaborator

@szepeviktor didn't propose his pull request yet, so I am going to merge this for now and create a beta to test it. Is it ok with you @j3j5?

@Kharhamel Kharhamel merged commit e47eeb5 into thecodingmachine:master May 9, 2022
@j3j5
Copy link
Contributor Author

j3j5 commented May 9, 2022

Yeah, I mean, it should fix the problem for now (hopefully) and later we can go with the "final solution" if y'all like it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot redeclare Safe\array_combine()

4 participants