use newer version of fsnotify for receiver to work correctly with cgroup v2#6435
Closed
rbjorklin wants to merge 1 commit intothanos-io:mainfrom
Closed
use newer version of fsnotify for receiver to work correctly with cgroup v2#6435rbjorklin wants to merge 1 commit intothanos-io:mainfrom
rbjorklin wants to merge 1 commit intothanos-io:mainfrom
Conversation
6acece4 to
8f7458e
Compare
8f7458e to
e346c4d
Compare
Contributor
|
Looks good to me, we have been missing watch events too, out of curiosity what changed in the newer version? i couldnt find a smoking gun in the changelog. |
2 tasks
Author
|
Don't hold me to this but I think it is this PR which was released with 1.5.4 that contained the relevant fix. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This change will use the newer version of fsnotify that is already in go.mod.
If possible, I would appreciate a cherry-pick of this and a 0.32.0 release.
Verification