Pass QueryEngineFactory by reference#6331
Merged
fpetkovski merged 2 commits intothanos-io:mainfrom May 3, 2023
Merged
Conversation
fpetkovski
reviewed
May 3, 2023
fpetkovski
approved these changes
May 3, 2023
1a58b18 to
d1edd26
Compare
Contributor
Author
Fixed |
rabenhorst
commented
May 3, 2023
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Cleanup Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
d1edd26 to
9264b2d
Compare
GiedriusS
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using both the GRPC and HTTP query API of one querier results in
duplicate metrics collector registration attempted. This happens because the queryEngineFactory is currently passed by value, so there will be two instances of the factory resulting in two engines being created when using both the GRPC and HTTP query API of the same querier. Since both engines will register the same metrics we get the duplication error. To fix this we change to passing the engine factory by reference in this PR.