Strip replica labels from series in Store Gateway#6296
Strip replica labels from series in Store Gateway#6296fpetkovski wants to merge 1 commit intothanos-io:mainfrom
Conversation
Store Gateway is currently the only store which does not strip replica labels from stores. This causes deduplication problems for certain cases where users need to deduplicate by labels stored in TSDB. This commit modifies store-gateway to strip replica labels when they are also stored in TSDB blocks. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
|
That PR only removes replica labels from external labels, but I thought we should also strip when they are part of the series. At least this is what we do for the receiver and sidecar. However, after my last comment, I think this would only mask the dedup problem that people are seeing in 0.31.0 and solve only a subset of issues. |
|
Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days. |
|
@fpetkovski I rebased this with the tests from main and it solved the problem in the Store GW. Problem's still present in Receive and Sidecar. Do you think you can extend the fix here to these other components? |
Store Gateway is currently the only store which does not strip replica labels from stores. This causes deduplication problems for certain cases where users need to deduplicate by labels stored in TSDB.
This commit modifies store-gateway to strip replica labels when they are also stored in TSDB blocks.
This is a partial fix for #6257.
Changes
Verification