Thanos, Prometheus and Golang version used: v0.30+
Object Storage Provider: N/A
What happened: Doc links on the website are not consistent between tip and versions >=v0.30. For example:
https://thanos.io/tip/proposals-done/202004-embedd-cortex-frontend.md/
vs
https://thanos.io/v0.32/proposals-done/202004-embedd-cortex-frontend/
(The addition of the .md suffix)
The links are the same for versions <=v0.29, presumably because of this Hugo section:
|
permalinks: |
|
# Generate those for every file. |
|
# TODO(bwplotka): Move to mdox + fixes to ensure we don't need to manually do this. |
|
# For now we added few entries for advance. |
|
tip: "/:sections/:filename.md" |
|
v0.29: "/:sections/:filename.md" |
|
v0.28: "/:sections/:filename.md" |
|
v0.27: "/:sections/:filename.md" |
|
v0.26: "/:sections/:filename.md" |
|
v0.25: "/:sections/:filename.md" |
|
v0.24: "/:sections/:filename.md" |
|
v0.23: "/:sections/:filename.md" |
|
v0.22: "/:sections/:filename.md" |
|
v0.21: "/:sections/:filename.md" |
|
v0.20: "/:sections/:filename.md" |
|
v0.19: "/:sections/:filename.md" |
|
v0.18: "/:sections/:filename.md" |
|
v0.17: "/:sections/:filename.md" |
|
v0.16: "/:sections/:filename.md" |
|
v0.15: "/:sections/:filename.md" |
|
v0.14: "/:sections/:filename.md" |
|
v0.13: "/:sections/:filename.md" |
|
v0.12: "/:sections/:filename.md" |
|
v0.11: "/:sections/:filename.md" |
|
v0.10: "/:sections/:filename.md" |
This breaks links between pages like on https://thanos.io/v0.33/components/query-frontend.md/#query-frontend, where there is a link to https://thanos.io/v0.33/proposals-done/202004-embedd-cortex-frontend.md/, but the page is actually at https://thanos.io/v0.33/proposals-done/202004-embedd-cortex-frontend/
What you expected to happen: Link paths should be the same so that users can easily switch between viewing a doc entry for different Thanos versions.
How to reproduce it (as minimally and precisely as possible): Test links like the above on the live site.
Full logs to relevant components: N/A
Anything else we need to know: N/A
Thanos, Prometheus and Golang version used: v0.30+
Object Storage Provider: N/A
What happened: Doc links on the website are not consistent between
tipand versions >=v0.30. For example:https://thanos.io/tip/proposals-done/202004-embedd-cortex-frontend.md/
vs
https://thanos.io/v0.32/proposals-done/202004-embedd-cortex-frontend/
(The addition of the
.mdsuffix)The links are the same for versions <=v0.29, presumably because of this Hugo section:
thanos/website/hugo.yaml
Lines 26 to 50 in c74a050
This breaks links between pages like on https://thanos.io/v0.33/components/query-frontend.md/#query-frontend, where there is a link to https://thanos.io/v0.33/proposals-done/202004-embedd-cortex-frontend.md/, but the page is actually at https://thanos.io/v0.33/proposals-done/202004-embedd-cortex-frontend/
What you expected to happen: Link paths should be the same so that users can easily switch between viewing a doc entry for different Thanos versions.
How to reproduce it (as minimally and precisely as possible): Test links like the above on the live site.
Full logs to relevant components: N/A
Anything else we need to know: N/A