Fix data race when enabling io threading #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShooterIT
commented
Oct 16, 2025
| /* Keep the client in the main thread to avoid data races between the | ||
| * connWrite call in startBgsaveForReplication and the client's event | ||
| * handler in IO threads. */ | ||
| if (c->tid != IOTHREAD_MAIN_THREAD_ID) keepClientInMainThread(c); |
Collaborator
Author
There was a problem hiding this comment.
this is very rare case, so i don't plan to back port it to old version, wdyt?
Owner
There was a problem hiding this comment.
okay, we also had a memory leak issue in cluster.c, perhaps we can list them as fixes in the PR description.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cluster-asm #105 +/- ##
==============================================
Coverage ? 75.99%
==============================================
Files ? 131
Lines ? 76249
Branches ? 0
==============================================
Hits ? 57947
Misses ? 18302
Partials ? 0
🚀 New features to boost your workflow:
|
tezc
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread sanitizer is happy now
https://github.com/ShooterIT/redis/actions/runs/18550564519