Conversation
447629b to
dc15891
Compare
| if ci.CidInfo.CurrentStorageInfo == nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Archives that are in progress don't have CurrentStorageInformation.
| internalSession string | ||
|
|
||
| // daemon vars | ||
| lock sync.Mutex |
There was a problem hiding this comment.
Adding missing lock for safety.
|
|
||
| // If the retrieval switched to executing, or failed we're done. | ||
| if ju.Status != archive.TrackedJobStatusSuccess { | ||
| return |
There was a problem hiding this comment.
Weird diff. The main intention is fixing that if this if is true, it will return without calling Commit() below.
The whole thing would work anyway, but it was skipping an intermediate state saving.
| timestamp := time.Unix(le.Res.LogEntry.Time, 0) | ||
| ch <- fmt.Sprintf("%s: %s", timestamp.Format("2006-01-02 15:04:05"), le.Res.LogEntry.Message) |
There was a problem hiding this comment.
When giving log messages about the retrieval, include the timestamp as to know how much time has passed between event/messages.
| initCmd.Flags().Bool("hard", false, "Discards all local changes if true") | ||
| initCmd.Flags().BoolP("yes", "y", false, "Skips the confirmation prompt if true") | ||
| initCmd.Flags().BoolP("quiet", "q", false, "Write minimal output") | ||
| // (jsign): disabled until this feature is usable in mainnet. |
There was a problem hiding this comment.
All (jsign) reverting, is to re-enable the hidden feature.
| services: | ||
| powergate: | ||
| image: textile/powergate:v2.0.0 | ||
| image: textile/powergate:v2.3.2-jsign |
There was a problem hiding this comment.
Need to change this to the new docker-image that will be created when textileio/powergate#807 gets merged and tagged.
| // <LOTUS-BUG-HACK> | ||
| ccid2, _ := cid.Decode(rootCid1) | ||
| err = ipfsPow.Pin().Add(context.Background(), path.IpldPath(ccid2)) | ||
| // </LOTUS-BUG-HACK> | ||
|
|
There was a problem hiding this comment.
The work done in Powergate PR is mostly to workaround this Lotus bug and not depending on a configuration that triggers the bug. So we can delete all this "hacks" that we had in this test.
| func StartPowergate(t util.TestingTWithCleanup) (*pc.Client, *httpapi.HttpApi) { | ||
| os.Setenv("LOTUS_ONLINEMODE", strconv.FormatBool(false)) |
There was a problem hiding this comment.
We don't use IpfsOnlineMode=true anymore in Lotus for Hub (root problem of all this). So we can simplify here.
| timestamp := time.Unix(le.Res.LogEntry.Time, 0) | ||
| ch <- fmt.Sprintf("%s: %s", timestamp.Format("2006-01-02 15:04:05"), le.Res.LogEntry.Message) |
There was a problem hiding this comment.
Same as before, also printing dates in hub buck archive watch
| @@ -50,6 +50,8 @@ var filQueryMiners = &cobra.Command{ | |||
| The sort-field flag can take the following values: | |||
There was a problem hiding this comment.
Basically, add sorting filters for retrievals.
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
This PR sits on top of textileio/powergate#807
We had this feature hidden because of a problem when configuring Lotus when using
IpfsOnlineMode=true, which didn't make retrievals possible. The Powergate PR workaround this problem, and unblocks the feature.This PR also added some extra fixes and sections in the Miner Index CLI.