Skip to content

Fix db listener deadlock#476

Merged
sanderpick merged 1 commit intotextileio:masterfrom
anyproto:fix/db-listener-deadlock
Dec 31, 2020
Merged

Fix db listener deadlock#476
sanderpick merged 1 commit intotextileio:masterfrom
anyproto:fix/db-listener-deadlock

Conversation

@dgtony
Copy link
Copy Markdown
Contributor

@dgtony dgtony commented Dec 17, 2020

Signed-off-by: Anton Dort-Golts dortgolts@gmail.com

@dgtony
Fix notifee deadlock on listener close
01728ac 
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
@sanderpick
Copy link
Copy Markdown
Contributor

sanderpick commented Dec 17, 2020

Hey @dgtony, what's the scenario where you're seeing the deadlock?

@dgtony
Copy link
Copy Markdown
Contributor Author

dgtony commented Dec 17, 2020

Just closing the DB as follows:

DB.Close() -> d.stateChangedNotifee.close() -> acquire notifee lock -> listener.Close() -> stateChangedNotifee.remove() -> try to re-enter notifee lock

sanderpick
sanderpick approved these changes Dec 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here... LGTM

@sanderpick sanderpick merged commit 717c3d9 into textileio:master Dec 31, 2020
@dgtony dgtony deleted the fix/db-listener-deadlock branch January 19, 2021 14:58
@dgtony dgtony mentioned this pull request Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sanderpick sanderpick sanderpick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgtony @sanderpick