Pass thread key and log key through client when calling NewDB#460
Merged
sanderpick merged 1 commit intotextileio:masterfrom Nov 2, 2020
Merged
Pass thread key and log key through client when calling NewDB#460sanderpick merged 1 commit intotextileio:masterfrom
sanderpick merged 1 commit intotextileio:masterfrom
Conversation
* Pass thread key and log key through NewDB and NewDBFromAddr * Handle null thread key Signed-off-by: Daniel Merrill <danielmerrill6@gmail.com>
sanderpick
approved these changes
Nov 2, 2020
Contributor
sanderpick
left a comment
There was a problem hiding this comment.
LGTM! Thanks for jumping in 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change log
Add
threadKey,logKeyandblockparams toNewDBat threads protobuf.Add
threadKeyandlogKeyparams toNewDBFromAddrat threads protobuf.Handle those params and pass them through to
Manager.Notes
Regenerating the pb file using
makemade a lot of changes, maybe because my local version ofprotocis newer. I tested the changes by running the client tests and manually by calling the function from the Space Daemon and all seems to be working, but if you need me to downgrade my protoc binary and regenerate let me know.Also please let me know if this is missing anything before being ready to merge.