Skip to content

jsonpatcher: fix gob-encode of old ts events#444

Merged
sanderpick merged 2 commits intotextileio:masterfrom
anyproto:fix-handle-old-ts
Sep 23, 2020
Merged

jsonpatcher: fix gob-encode of old ts events#444
sanderpick merged 2 commits intotextileio:masterfrom
anyproto:fix-handle-old-ts

Conversation

@requilence
Copy link
Copy Markdown
Contributor

@requilence requilence commented Sep 22, 2020

fixes #443

@requilence requilence mentioned this pull request Sep 22, 2020
Closed
@requilence
jsonpatcher: fix gob-encode of old ts events
728db56 
Signed-off-by: requilence <requilence@gmail.com>
@requilence
Copy link
Copy Markdown
Contributor Author

requilence commented Sep 22, 2020 •
edited
Loading

I've added gob.Encode checks into the existing test in jsonpatcher_test.go instead of separate test in the db pkg. This seems not very correct, because this way we also need to do gob.Register in test so we don't actually test the db pkg. Let me know if you are ok with it, or it's better to do a separate test

sanderpick
sanderpick approved these changes Sep 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@sanderpick
Copy link
Copy Markdown
Contributor

sanderpick commented Sep 22, 2020

I'm okay with this test... thanks 🙏

sanderpick
sanderpick reviewed Sep 22, 2020
View reviewed changes
@requilence
jsonpatcher: fix the migration test
8f33b61 
Signed-off-by: requilence <requilence@gmail.com>
@sanderpick sanderpick merged commit 63bb7d0 into textileio:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sanderpick sanderpick sanderpick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dispatcher broken for old-style event with time.Time

2 participants

@requilence @sanderpick